Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1960] API for messages preview in source #7510

Merged
merged 37 commits into from
Feb 10, 2025
Merged

[NU-1960] API for messages preview in source #7510

merged 37 commits into from
Feb 10, 2025

Conversation

pielas
Copy link
Contributor

@pielas pielas commented Jan 29, 2025

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@pielas pielas changed the title Feature/nu 1960 messages preview in source [NU-1960] API for messages preview in source Feb 3, 2025
@pielas pielas requested a review from arkadius February 3, 2025 16:00
arkadius
arkadius reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, a few small comments added and one comment about endpoint naming.

designer/server/src/main/scala/pl/touk/nussknacker/ui/api/description/NodesApiEndpoints.scala Outdated Show resolved Hide resolved
...er/src/main/scala/pl/touk/nussknacker/engine/definition/test/ModelDataTestInfoProvider.scala Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/api/description/NodesApiEndpoints.scala Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/api/description/NodesApiEndpoints.scala Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/api/NodesApiHttpService.scala Outdated Show resolved Hide resolved
@pielas pielas requested a review from arkadius February 6, 2025 12:58
arkadius
arkadius reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments resolved, a few added. Please take a look at failing tests as well.

@pielas pielas merged commit e359386 into staging Feb 10, 2025
18 checks passed
@pielas pielas deleted the feature/NU-1960-messages-preview-in-source branch February 10, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pielas @arkadius